Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Mapping instead of Dict, Sequence instead of List #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Thyrst
Copy link

@Thyrst Thyrst commented Feb 6, 2024

Problem

Describe the purpose of this change. What problem is being solved and why?

Solution

Using Mapping and Sequence where appropriate.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Viz Steps To Reproduce in the linked issue.

To test the fix, change pinecone-client version to this branch and run Pyright again.

pip uninstall pinecone-client && pip install git+https://github.com/Thyrst/pinecone-python-client.git@generic_types
pyright main.py

@charles-dyfis-net
Copy link

Is there a reason this is in draft?

@Thyrst Thyrst marked this pull request as ready for review February 22, 2024 10:48
@Thyrst
Copy link
Author

Thyrst commented Feb 22, 2024

Is there a reason this is in draft?

It may not cover all places that need change but is ok to be merged. Marked it as ready.

@jhamon
Copy link
Collaborator

jhamon commented Feb 23, 2024

I appreciate the effort here, but code in the pinecone/core/ directory is generated off some things that are currently in a private repo. So i'll need to recreate these changes there before we can rebase and merge this PR.

@Thyrst
Copy link
Author

Thyrst commented Feb 24, 2024

I appreciate the effort here, but code in the pinecone/core/ directory is generated off some things that are currently in a private repo. So i'll need to recreate these changes there before we can rebase and merge this PR.

I see, thanks for the update. You can let me know once it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants