Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinecone-client > pinecone #333

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

pinecone-client > pinecone #333

wants to merge 2 commits into from

Conversation

tdonia
Copy link
Contributor

@tdonia tdonia commented Apr 19, 2024

Per pypi/support#2432 (comment) -- we have the pinecone package name on PyPI

Problem

This is a rough first pass at updating the package name on PyPI to pinecone. It doesn't attempt preserve the prior package workflow -- we may want to continue to publish to both for some period of time? We may also want to update the publishing workflow first, then doc changes later.

Solution

Updated Readmes, inline docs, and github workflows to support pinecone instead of pinecone-client

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here): Package name update

Test Plan

  • Does it publish to the new namespace?
  • How much work do we have to do to help users migrate from pinecone-client -- i.e. are there any automatic redirects, or is this a manual deprecation?

@tdonia tdonia marked this pull request as draft April 19, 2024 15:24
Copy link

@aulorbe aulorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just lurking, but LGTM!

@ssmith-pc
Copy link
Contributor

I don't have deep experience with PyPI, but this seems relevant:
https://peps.python.org/pep-0423/#how-to-rename-a-project

@tdonia tdonia force-pushed the tdonia/update-pypi-package branch from 96a95bb to 0f46161 Compare April 26, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants