Adjusting inference plugin dependency #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
approved these changes
Aug 1, 2024
ssmith-pc
approved these changes
Aug 1, 2024
pyproject.toml
Outdated
| @@ -68,7 +68,7 @@ lz4 = { version = ">=3.1.3", optional = true } | |||
| protobuf = { version = "^4.25", optional = true } | |||
| protoc-gen-openapiv2 = {version = "^0.0.1", optional = true } | |||
| pinecone-plugin-interface = "^0.0.7" | |||
| pinecone-plugin-inference = ">=1.0.2" | |||
| pinecone-plugin-inference = ">=1.0.3" | |||
There was a problem hiding this comment.
Can we change it to the caret style ^1.0.3? That will restrict it to ">=1.0.3, <2.0.0". If inference is doing a major version upgrade, then it should probably result in a major version upgrade for the main client
ssmith-pc
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #378 raised a concern about a circular dependency relationship between the
pinecone-clientandpinecone-plugin-inferenceplugin which implements new Inference API functionality.Solution
We have updated the plugin to remove it's declared dependency on pinecone-client, and now need to update the pinecone-client to consume that update.
Type of Change