Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add missing dateutil dep #391

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[Fix] Add missing dateutil dep #391

merged 1 commit into from
Sep 19, 2024

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Sep 19, 2024

Problem

SDK version 5.3.0 was accidentally shipped with a missing dependency. This wasn't caught in testing because the dependency was present in our poetry.lock, which is used when installing in CI, but not in pyproject.toml so it wasn't included for the published package. We got into this state because we used to have a dependency on python-dateutil which was removed and later re-added when date parsing was needed for support of import endpoints (added 5.3.0).

Additional manual testing in google colab didn't catch this either because that environment loads python-dateutil as part of the default environment. 🤦‍♀️

Solution

Add missing dependency.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

@jhamon jhamon marked this pull request as ready for review September 19, 2024 18:43
@jhamon jhamon merged commit c85ca40 into main Sep 19, 2024
84 checks passed
@jhamon jhamon deleted the jhamon/missing-dateutil-dep branch September 19, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants