Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests for weird ids string encoding #412

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Disable tests for weird ids string encoding #412

merged 2 commits into from
Nov 11, 2024

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Nov 11, 2024

Problem

We have a very large test matrix to check that different kinds of strings are handled properly. But we probably don't get that much value out of running these for every single PR.

Solution

Gate these tests on a boolean so I can only run these when desired instead of on every PR. It's most relevant to run them when changing dependencies or python versions.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

@jhamon jhamon marked this pull request as ready for review November 11, 2024 15:16
@jhamon jhamon merged commit 950a9e8 into main Nov 11, 2024
85 checks passed
@jhamon jhamon deleted the jhamon/skip-weird branch November 11, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant