Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Helpful error when incorrectly instantiating Index client #418

Merged
merged 5 commits into from
Nov 18, 2024
Merged

[Feat] Helpful error when incorrectly instantiating Index client #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28695f3
[Feat] Helpful error when incorrectly instantiating Index client
jhamon Nov 15, 2024
67b69b9
Fix tests broken by rename
jhamon Nov 15, 2024
720b9a9
Commit missing file
jhamon Nov 15, 2024
8b6d97d
Add integration test
jhamon Nov 15, 2024
718bbab
Adjust test assertion
jhamon Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pinecone/control/pinecone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
from pinecone.models import ServerlessSpec, PodSpec, IndexModel, IndexList, CollectionList
from .langchain_import_warnings import _build_langchain_attribute_error_message

from pinecone.data import Index
from pinecone.data import _Index

from pinecone_plugin_interface import load_and_install as install_plugins

Expand Down Expand Up @@ -788,7 +788,7 @@ def Index(self, name: str = "", host: str = "", **kwargs):
# Otherwise, get host url from describe_index using the index name
index_host = self.index_host_store.get_host(self.index_api, self.config, name)

return Index(
return _Index(
host=index_host,
api_key=api_key,
pool_threads=pt,
Expand Down
Loading
Loading