Add @spruce release to user-agent #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
changed the base branch from
main
to
adenoble/update-validator-for-literals
jhamon
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Instead of reading from packageInfo, I would prefer to read an env var that we can set in CI during the build/release process. That way we don't end up with residual code stuff that is spruce-specific when we merge to main later. You can ship this as is if you want, but if you do, you should make a ticket to clean it up later.
austin-denoble
force-pushed
the
adenoble/update-validator-for-literals
branch
from
2ad2a18 to
c655eae
Compare
Base automatically changed from
adenoble/update-validator-for-literals
to
spruce
November 7, 2023 19:22
austin-denoble
force-pushed
the
adenoble/add-spruce-user-agent
branch
from
20435ae to
28b38d6
Compare
That does make more sense. I'll get that changed in this PR. |
jhamon
approved these changes
Nov 7, 2023
austin-denoble
added a commit
that referenced
this pull request
Dec 27, 2023
_This revision is dependent on a previous branches / PRs. These will need to be reviewed and merged first:_ - #153 - #154 ## Problem We want to be able to track usage specific to the spruce release of the client. ## Solution - Update `buildUserAgent` logic to check for `packageInfo.release`, and append to the user agent if present. - Update `release-spruce-dev` and `release-spruce` workflows to add `@spruce` to `version.json` during these specific releases. ## Type of Change - [X] New feature (non-breaking change which adds functionality) ## Test Plan We will need to release through either the `release-spruce` or `release-spruce-dev` workflows and validate the `version.json` file has the proper info, and the `release` is appended to the user agent header.
austin-denoble
added a commit
that referenced
this pull request
Jan 13, 2024
_This revision is dependent on a previous branches / PRs. These will need to be reviewed and merged first:_ - #153 - #154 We want to be able to track usage specific to the spruce release of the client. - Update `buildUserAgent` logic to check for `packageInfo.release`, and append to the user agent if present. - Update `release-spruce-dev` and `release-spruce` workflows to add `@spruce` to `version.json` during these specific releases. - [X] New feature (non-breaking change which adds functionality) We will need to release through either the `release-spruce` or `release-spruce-dev` workflows and validate the `version.json` file has the proper info, and the `release` is appended to the user agent header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revision is dependent on a previous branches / PRs. These will need to be reviewed and merged first:
Problem
We want to be able to track usage specific to the spruce release of the client.
Solution
buildUserAgentlogic to check forpackageInfo.release, and append to the user agent if present.release-spruce-devandrelease-spruceworkflows to add@sprucetoversion.jsonduring these specific releases.Type of Change
Test Plan
We will need to release through either the
release-spruceorrelease-spruce-devworkflows and validate theversion.jsonfile has the proper info, and thereleaseis appended to the user agent header.