Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spruce] Regenerate OpenAPI core, update query and fetch to return usage / readUnits #183

Merged
merged 3 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/control/__tests__/configureIndex.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { configureIndex } from '../configureIndex';
import { ManagePodIndexesApi } from '../../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../../pinecone-generated-ts-fetch';
import type {
ConfigureIndexOperationRequest,
IndexModel,
Expand Down Expand Up @@ -29,7 +29,7 @@ describe('configureIndex', () => {
const fakeConfigure: (
req: ConfigureIndexOperationRequest
) => Promise<IndexModel> = jest.fn().mockResolvedValue(indexModel);
const IOA = { configureIndex: fakeConfigure } as ManagePodIndexesApi;
const IOA = { configureIndex: fakeConfigure } as ManageIndexesApi;

const returned = await configureIndex(IOA)('index-name', {
replicas: 4,
Expand Down
4 changes: 2 additions & 2 deletions src/control/__tests__/configureIndex.validation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@

import { configureIndex } from '../configureIndex';
import { PineconeArgumentError } from '../../errors';
import { ManagePodIndexesApi } from '../../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../../pinecone-generated-ts-fetch';

describe('configureIndex argument validations', () => {
let MPIA: ManagePodIndexesApi;
let MPIA: ManageIndexesApi;
beforeEach(() => {
MPIA = { configureIndex: jest.fn() };
jest.mock('../../pinecone-generated-ts-fetch', () => ({
Expand Down
4 changes: 2 additions & 2 deletions src/control/__tests__/createCollection.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createCollection } from '../createCollection';
import { PineconeArgumentError } from '../../errors';
import { ManagePodIndexesApi } from '../../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../../pinecone-generated-ts-fetch';
import type {
CollectionModel,
CreateCollectionOperationRequest,
Expand Down Expand Up @@ -56,7 +56,7 @@ const setOpenAPIResponse = (fakeCreateCollectionResponse) => {
const IOA = {
createCollection: fakeCreateCollection,
listIndexes: fakeListIndexes,
} as ManagePodIndexesApi;
} as ManageIndexesApi;

return IOA;
};
Expand Down
4 changes: 2 additions & 2 deletions src/control/__tests__/createIndex.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createIndex } from '../createIndex';
import { ManagePodIndexesApi } from '../../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../../pinecone-generated-ts-fetch';
import type {
CreateIndexOperationRequest,
DescribeIndexRequest,
Expand Down Expand Up @@ -43,7 +43,7 @@ const setupCreateIndexResponse = (
const MPIA = {
createIndex: fakeCreateIndex,
describeIndex: fakeDescribeIndex,
} as ManagePodIndexesApi;
} as ManageIndexesApi;

return MPIA;
};
Expand Down
6 changes: 3 additions & 3 deletions src/control/__tests__/createIndex.validation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@

import { createIndex } from '../createIndex';
import { PineconeArgumentError } from '../../errors';
import { ManagePodIndexesApi } from '../../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../../pinecone-generated-ts-fetch';

// TODO: Update tests to cover all nested properties inside spec once validator.ts is updated
describe('createIndex argument validations', () => {
let MPIA: ManagePodIndexesApi;
let MPIA: ManageIndexesApi;
beforeEach(() => {
MPIA = { createIndex: jest.fn() };
jest.mock('../../pinecone-generated-ts-fetch', () => ({
ManagePodIndexesApi: MPIA,
ManageIndexesApi: MPIA,
}));
});

Expand Down
4 changes: 2 additions & 2 deletions src/control/__tests__/deleteCollection.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { deleteCollection } from '../deleteCollection';
import { PineconeArgumentError } from '../../errors';
import { ManagePodIndexesApi } from '../../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../../pinecone-generated-ts-fetch';
import type {
DeleteCollectionRequest,
CollectionList,
Expand All @@ -20,7 +20,7 @@ const setupMocks = (
deleteCollection: fakeDeleteCollection,
listCollections: fakeListCollections,
};
return IOA as ManagePodIndexesApi;
return IOA as ManageIndexesApi;
};

describe('deleteCollection', () => {
Expand Down
4 changes: 2 additions & 2 deletions src/control/__tests__/describeCollection.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { describeCollection } from '../describeCollection';
import { PineconeArgumentError } from '../../errors';
import { ManagePodIndexesApi } from '../../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../../pinecone-generated-ts-fetch';
import type {
DescribeCollectionRequest,
CollectionList,
Expand All @@ -23,7 +23,7 @@ const setupMocks = (
describeCollection: fakeDescribeCollection,
listCollections: fakeListCollections,
};
return IOA as ManagePodIndexesApi;
return IOA as ManageIndexesApi;
};

describe('describeCollection', () => {
Expand Down
4 changes: 2 additions & 2 deletions src/control/configureIndex.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {
ManagePodIndexesApi,
ManageIndexesApi,
IndexModel,
ConfigureIndexRequestSpecPod,
} from '../pinecone-generated-ts-fetch';
Expand All @@ -18,7 +18,7 @@ const ConfigureIndexOptionsSchema = Type.Object(
{ additionalProperties: false }
);

export const configureIndex = (api: ManagePodIndexesApi) => {
export const configureIndex = (api: ManageIndexesApi) => {
const indexNameValidator = buildValidator(
'The first argument to configureIndex',
IndexNameSchema
Expand Down
4 changes: 2 additions & 2 deletions src/control/createCollection.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {
CollectionModel,
CreateCollectionRequest,
ManagePodIndexesApi,
ManageIndexesApi,
} from '../pinecone-generated-ts-fetch';
import { buildConfigValidator } from '../validator';
import { CollectionNameSchema, IndexNameSchema } from './types';
Expand All @@ -15,7 +15,7 @@ const CreateCollectionOptionsSchema = Type.Object(
{ additionalProperties: false }
);

export const createCollection = (api: ManagePodIndexesApi) => {
export const createCollection = (api: ManageIndexesApi) => {
const validator = buildConfigValidator(
CreateCollectionOptionsSchema,
'createCollection'
Expand Down
6 changes: 3 additions & 3 deletions src/control/createIndex.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {
CreateIndexRequest,
IndexModel,
ManagePodIndexesApi,
ManageIndexesApi,
CreateIndexRequestMetricEnum,
} from '../pinecone-generated-ts-fetch';
import { buildConfigValidator } from '../validator';
Expand Down Expand Up @@ -69,7 +69,7 @@ const CreateIndexOptionsSchema = Type.Object(
{ additionalProperties: false }
);

export const createIndex = (api: ManagePodIndexesApi) => {
export const createIndex = (api: ManageIndexesApi) => {
const validator = buildConfigValidator(
CreateIndexOptionsSchema,
'createIndex'
Expand Down Expand Up @@ -105,7 +105,7 @@ export const createIndex = (api: ManagePodIndexesApi) => {
};

const waitUntilIndexIsReady = async (
api: ManagePodIndexesApi,
api: ManageIndexesApi,
indexName: string,
seconds: number = 0
): Promise<IndexModel> => {
Expand Down
4 changes: 2 additions & 2 deletions src/control/deleteCollection.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ManagePodIndexesApi } from '../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../pinecone-generated-ts-fetch';
import { buildConfigValidator } from '../validator';
import { CollectionNameSchema } from './types';
import type { CollectionName } from './types';
Expand All @@ -8,7 +8,7 @@ import type { CollectionName } from './types';
*/
export type DeleteCollectionOptions = CollectionName;

export const deleteCollection = (api: ManagePodIndexesApi) => {
export const deleteCollection = (api: ManageIndexesApi) => {
const validator = buildConfigValidator(
CollectionNameSchema,
'deleteCollection'
Expand Down
4 changes: 2 additions & 2 deletions src/control/deleteIndex.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { ManagePodIndexesApi } from '../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../pinecone-generated-ts-fetch';
import { buildConfigValidator } from '../validator';
import { IndexName, IndexNameSchema } from './types';

/** The name of index to delete */
export type DeleteIndexOptions = IndexName;

export const deleteIndex = (api: ManagePodIndexesApi) => {
export const deleteIndex = (api: ManageIndexesApi) => {
const validator = buildConfigValidator(IndexNameSchema, 'deleteIndex');

return async (indexName: DeleteIndexOptions): Promise<void> => {
Expand Down
4 changes: 2 additions & 2 deletions src/control/describeCollection.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {
ManagePodIndexesApi,
ManageIndexesApi,
CollectionModel,
} from '../pinecone-generated-ts-fetch';
import { buildConfigValidator } from '../validator';
Expand All @@ -11,7 +11,7 @@ import type { CollectionName } from './types';
*/
export type DescribeCollectionOptions = CollectionName;

export const describeCollection = (api: ManagePodIndexesApi) => {
export const describeCollection = (api: ManageIndexesApi) => {
const validator = buildConfigValidator(
CollectionNameSchema,
'describeCollection'
Expand Down
7 changes: 2 additions & 5 deletions src/control/describeIndex.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import { buildConfigValidator } from '../validator';
import {
IndexModel,
ManagePodIndexesApi,
} from '../pinecone-generated-ts-fetch';
import { IndexModel, ManageIndexesApi } from '../pinecone-generated-ts-fetch';
import { IndexNameSchema } from './types';
import type { IndexName } from './types';

/** The name of the index to describe */
export type DescribeIndexOptions = IndexName;

export const describeIndex = (api: ManagePodIndexesApi) => {
export const describeIndex = (api: ManageIndexesApi) => {
const validator = buildConfigValidator(IndexNameSchema, 'describeIndex');

const removeDeprecatedFields = (result: any) => {
Expand Down
6 changes: 3 additions & 3 deletions src/control/indexOperationsBuilder.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {
ManagePodIndexesApi,
ManageIndexesApi,
Configuration,
} from '../pinecone-generated-ts-fetch';
import {
Expand All @@ -14,7 +14,7 @@ import type { ConfigurationParameters as IndexOperationsApiConfigurationParamete

export const indexOperationsBuilder = (
config: PineconeConfiguration
): ManagePodIndexesApi => {
): ManageIndexesApi => {
const { apiKey } = config;
const controllerPath =
normalizeUrl(config.controllerHostUrl) || 'https://api.pinecone.io';
Expand All @@ -31,5 +31,5 @@ export const indexOperationsBuilder = (
middleware,
};

return new ManagePodIndexesApi(new Configuration(apiConfig));
return new ManageIndexesApi(new Configuration(apiConfig));
};
4 changes: 2 additions & 2 deletions src/control/listCollections.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import {
ManagePodIndexesApi,
ManageIndexesApi,
CollectionList,
} from '../pinecone-generated-ts-fetch';

export const listCollections = (api: ManagePodIndexesApi) => {
export const listCollections = (api: ManageIndexesApi) => {
return async (): Promise<CollectionList> => {
const results = await api.listCollections();

Expand Down
4 changes: 2 additions & 2 deletions src/control/listIndexes.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ManagePodIndexesApi, IndexList } from '../pinecone-generated-ts-fetch';
import { ManageIndexesApi, IndexList } from '../pinecone-generated-ts-fetch';

export const listIndexes = (api: ManagePodIndexesApi) => {
export const listIndexes = (api: ManageIndexesApi) => {
return async (): Promise<IndexList> => {
const response = await api.listIndexes();

Expand Down
11 changes: 10 additions & 1 deletion src/data/fetch.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import { buildConfigValidator } from '../validator';
import { VectorOperationsProvider } from './vectorOperationsProvider';
import { RecordIdSchema } from './types';
import type { PineconeRecord, RecordId, RecordMetadata } from './types';
import type {
OperationUsage,
PineconeRecord,
RecordId,
RecordMetadata,
} from './types';
import { Type } from '@sinclair/typebox';

const RecordIdsArray = Type.Array(RecordIdSchema, { minItems: 1 });
Expand All @@ -21,6 +26,9 @@ export type FetchResponse<T extends RecordMetadata = RecordMetadata> = {

/** The namespace where records were fetched. */
namespace: string;

/** The usage information for the fetch operation. */
usage?: OperationUsage;
};

export class FetchCommand<T extends RecordMetadata = RecordMetadata> {
Expand All @@ -46,6 +54,7 @@ export class FetchCommand<T extends RecordMetadata = RecordMetadata> {
return {
records: response.vectors ? response.vectors : {},
namespace: response.namespace ? response.namespace : '',
...(response.usage && { usage: response.usage }),
} as FetchResponse<T>;
}
}
5 changes: 2 additions & 3 deletions src/data/indexHostSingleton.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ManagePodIndexesApi } from '../pinecone-generated-ts-fetch';
import { ManageIndexesApi } from '../pinecone-generated-ts-fetch';
import type { PineconeConfiguration } from './types';
import type { IndexName } from '../control';
import { describeIndex, indexOperationsBuilder } from '../control';
Expand All @@ -10,8 +10,7 @@ import { normalizeUrl } from '../utils';
// and index, so we cache them in a singleton for reuse.
export const IndexHostSingleton = (function () {
const hostUrls = {}; // map of apiKey-indexName to hostUrl
let indexOperationsApi: InstanceType<typeof ManagePodIndexesApi> | null =
null;
let indexOperationsApi: InstanceType<typeof ManageIndexesApi> | null = null;

const _describeIndex = async (
config: PineconeConfiguration,
Expand Down
5 changes: 5 additions & 0 deletions src/data/query.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { buildConfigValidator } from '../validator';
import {
OperationUsage,
RecordIdSchema,
RecordSparseValuesSchema,
RecordValues,
Expand Down Expand Up @@ -125,6 +126,9 @@ export type QueryResponse<T extends RecordMetadata = RecordMetadata> = {

/** The namespace where the query was executed. */
namespace: string;

/** The usage information for the query operation. */
usage?: OperationUsage;
};

export class QueryCommand<T extends RecordMetadata = RecordMetadata> {
Expand All @@ -150,6 +154,7 @@ export class QueryCommand<T extends RecordMetadata = RecordMetadata> {
return {
matches: matches as Array<ScoredPineconeRecord<T>>,
namespace: this.namespace,
...(results.usage && { usage: results.usage }),
};
}
}
10 changes: 10 additions & 0 deletions src/data/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,13 @@ export type PineconeRecord<T extends RecordMetadata = RecordMetadata> = {
*/
metadata?: T;
};

/**
* Metadata detailing usage units for a specific operation.
*/
export type OperationUsage = {
/**
* The number of read units consumed by this operation.
*/
readUnits?: string;
};
3 changes: 2 additions & 1 deletion src/pinecone-generated-ts-fetch/.openapi-generator/FILES
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.openapi-generator-ignore
apis/ManagePodIndexesApi.ts
apis/ManageIndexesApi.ts
apis/VectorOperationsApi.ts
apis/index.ts
index.ts
Expand Down Expand Up @@ -40,6 +40,7 @@ models/SparseValues.ts
models/UpdateRequest.ts
models/UpsertRequest.ts
models/UpsertResponse.ts
models/Usage.ts
models/Vector.ts
models/index.ts
runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export interface DescribeIndexRequest {
/**
*
*/
export class ManagePodIndexesApi extends runtime.BaseAPI {
export class ManageIndexesApi extends runtime.BaseAPI {

/**
* This operation specifies the pod type and number of replicas for an index.
Expand Down
2 changes: 1 addition & 1 deletion src/pinecone-generated-ts-fetch/apis/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* tslint:disable */
/* eslint-disable */
export * from './ManagePodIndexesApi';
export * from './ManageIndexesApi';
export * from './VectorOperationsApi';
Loading