Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recordCount -> vectorCount #189

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Update recordCount -> vectorCount #189

merged 1 commit into from
Jan 14, 2024

Conversation

austin-denoble
Copy link
Contributor

Problem

Collections still return vector_count and we've updated the OpenAPI spec.

Solution

  • Regenerate OpenAPI core
  • Fix small issue in merge workflow

@austin-denoble austin-denoble requested a review from jhamon January 14, 2024 06:25
jhamon
jhamon approved these changes Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@jhamon jhamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@austin-denoble austin-denoble merged commit 7284b02 into main Jan 14, 2024
26 checks passed
@austin-denoble austin-denoble deleted the adenoble/update-vector-count branch January 14, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamon jhamon jhamon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austin-denoble @jhamon