Remove git submodule cmds and update Vercel cmds in external-app tests
#316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
approved these changes
Dec 16, 2024
aulorbe
changed the title
git submodule cmdsgit submodule cmds and update Vercel cmds in external-app tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The addition of
git submodule...commands was causing issues with thets-fetchgenerator. Exactly why it was causing those issues remains an open question, but this way originally worked and thegit submodulecmds were just added as a safety precaution. We can remove them since they're causing unnecessary cruft.Addition
This PR includes additional work done to the GH actions file for the external app Edge runtime testing: the Vercel cmds were out of date, causing CI to fail.