Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disappears acceptance test for index resource. #21

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

skyscrapr
Copy link
Contributor

Problem

Add disappears test for index to handle scenarios where the index is deleted manually from the console.

Solution

There is a common pattern use in the terraform provider for AWS: docs

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Test output :
Running tool: /opt/homebrew/bin/go test -timeout 300s -run ^TestAccIndexResource_dimension$ github.com/pinecone-io/terraform-provider-pinecone/pinecone/provider

ok github.com/pinecone-io/terraform-provider-pinecone/pinecone/provider 12.636s

@skyscrapr skyscrapr changed the title Bugfix 6 Add disappears acceptance test for index resource. Apr 11, 2024
@skyscrapr
Copy link
Contributor Author

closes #6

@haruska
Copy link
Collaborator

haruska commented Apr 11, 2024

@skyscrapr can you rebase this with main? I improved the GH Action workflow to allow approval of acceptance testing with secrets.

@haruska haruska merged commit 666b8ea into pinecone-io:main Apr 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants