Add new property to mark the initial size for the new region. #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
bufferflies
force-pushed
the
split_size
branch
from
cd51f44 to
7b79c6e
Compare
SpadeA-Tang
reviewed
Sep 1, 2023
proto/raft_cmdpb.proto
Outdated
Comment on lines
149
to
150
| // It should be false iff the region split by user key such as split table or create partion table etc, and new region's size should be zero. | ||
| // It should be true iff the region's load reach the threshold such as size、keys、load check etc, and new region's size will amortize the origin region. |
There was a problem hiding this comment.
Maybe change to "It determines whether the split-off regions amortize the region size of the source region. In some cases, such as ..., the split-off regions won't have any data, so they should't amortize the source region's region size." ?
There was a problem hiding this comment.
I will change the behavior description.
SpadeA-Tang
approved these changes
Sep 1, 2023
rleungx
reviewed
Sep 1, 2023
protoc-3.15.8-linux-x86_64.zip
Outdated
Signed-off-by: bufferflies <[email protected]>
bufferflies
force-pushed
the
split_size
branch
from
130d3c0 to
a6c47ca
Compare
rleungx
reviewed
Sep 1, 2023
rleungx
reviewed
Sep 1, 2023
Signed-off-by: bufferflies <[email protected]>
rleungx
approved these changes
Sep 4, 2023
|
/merge |
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.