Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get started: update outdated command of running tests #232

Conversation

Octobug
Copy link
Contributor

@Octobug Octobug commented Jun 13, 2023

What issue does this PR solve?

  • close: none of the existing issues is relative to this PR.

What is changed:

The gotest makefile target was removed by pingcap/tidb#36530 due to issue pingcap/tidb#36493. This PR:

@zhangyangyu
Copy link
Member

@hawkingrei could you take a look? Seems similar to your #223

@Octobug
Copy link
Contributor Author

Octobug commented Jun 14, 2023

@hawkingrei could you take a look? Seems similar to your #223

It is similar to #223 . #223 has a ci: subject and a ❌ CI status, so I just took a glance at it and didn't check it out yesterday. = =

@hawkingrei
Copy link
Member

@tiancaiamao PTAL

@Octobug
Copy link
Contributor Author

Octobug commented Jun 27, 2023

This PR is getting stale, do I need to update anything?

@zhangyangyu zhangyangyu merged commit 0a14ee2 into pingcap:master Jun 27, 2023
@Octobug Octobug deleted the get-started/update-outdated-command-of-running-tests branch July 27, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants