This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
backend/tidb: temporarily disable the strict-mode value check in tidb backend #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
LGTM |
|
/lgtm |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Jan 18, 2021
glorv
added a commit
that referenced
this pull request
Jan 29, 2021
… backend (#551) * temporarily disable the strict-mode value check in tidb backend since it's buggy * add link to related issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#378 added string value check in tidb backend if the SQL mode is strict. But this causes #550 because tidb backend doesn't fetch the full table meta which causes CastValue panic.
What is changed and how it works?
Disable this feature before we come up with a correct solution.
Check List
Tests
Side effects
Related changes