-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The backup cleaner can't clean the CR at the schedule
phase before task start
#5967
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
+ Coverage 57.19% 59.98% +2.78%
==========================================
Files 259 263 +4
Lines 33233 45664 +12431
==========================================
+ Hits 19008 27392 +8384
- Misses 12291 16209 +3918
- Partials 1934 2063 +129
|
/run-pull-e2e-kind-br |
/run-pull-e2e-kind-br |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
/cherry-pick release-1.6 |
@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.6 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherry-pick release-1.5 |
@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…task start (#5967) (#5971) Co-authored-by: RidRisR <[email protected]>
…task start (#5967) (#5972) Co-authored-by: RidRisR <[email protected]>
…task start (pingcap#5967) Co-authored-by: Cody (Xuecheng) Zhang <[email protected]>
What problem does this PR solve?
Close #5968
What is changed and how does it work?
Set the status of the not started CR to stop phase.
The task haven't been started so it is ok to delete it immediately.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.