Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The backup cleaner can't clean the CR at the schedule phase before task start #5967

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Dec 9, 2024

What problem does this PR solve?

Close #5968

What is changed and how does it work?

Set the status of the not started CR to stop phase.
The task haven't been started so it is ok to delete it immediately.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 December 9, 2024 08:15
@ti-chi-bot ti-chi-bot bot added the size/M label Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.98%. Comparing base (a16b2e8) to head (c7d010e).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5967      +/-   ##
==========================================
+ Coverage   57.19%   59.98%   +2.78%     
==========================================
  Files         259      263       +4     
  Lines       33233    45664   +12431     
==========================================
+ Hits        19008    27392    +8384     
- Misses      12291    16209    +3918     
- Partials     1934     2063     +129     
Flag Coverage Δ
e2e 20.52% <100.00%> (?)
unittest 56.98% <0.00%> (-0.22%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/L and removed size/M labels Dec 10, 2024
tests/e2e/br/br.go Outdated Show resolved Hide resolved
@RidRisR RidRisR requested a review from csuzhangxc December 10, 2024 05:45
@RidRisR
Copy link
Contributor Author

RidRisR commented Dec 10, 2024

/run-pull-e2e-kind-br

@RidRisR
Copy link
Contributor Author

RidRisR commented Dec 10, 2024

/run-pull-e2e-kind-br

Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-10 09:18:24.328626138 +0000 UTC m=+343694.417428681: ☑️ agreed by csuzhangxc.
  • 2024-12-10 09:18:31.772845043 +0000 UTC m=+343701.861647585: ✖️🔁 reset by csuzhangxc.

Copy link
Contributor

ti-chi-bot bot commented Dec 10, 2024

New changes are detected. LGTM label has been removed.

@csuzhangxc
Copy link
Member

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.6 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc csuzhangxc merged commit 74db3ac into pingcap:master Dec 10, 2024
5 of 6 checks passed
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #5971.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5972.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Dec 10, 2024
csuzhangxc pushed a commit that referenced this pull request Dec 11, 2024
@RidRisR RidRisR deleted the schedule branch December 11, 2024 02:54
RidRisR added a commit to RidRisR/tidb-operator that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The backup cleaner can't clean the CR at the schedule phase before task start
4 participants