Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: cleanup topo keys properly #58984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

domain: cleanup topo keys properly #58984

wants to merge 1 commit into from

Conversation

iosmanthus
Copy link
Contributor

@iosmanthus iosmanthus commented Jan 16, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58983

Problem Summary:

TiDB should remove the topology keys while closing the domain.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviours
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2025

Hi @iosmanthus. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jan 16, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 16, 2025

Hi @iosmanthus. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 16, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-16 08:26:30.469870596 +0000 UTC m=+193461.924916745: ☑️ agreed by tangenta.

@tangenta
Copy link
Contributor

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, ystaticy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2025

@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jan 16, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2025

@iosmanthus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 7690e1c link true /test build
idc-jenkins-ci-tidb/check_dev 7690e1c link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tiprow tiprow
Copy link

tiprow bot commented Jan 16, 2025

@iosmanthus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 7690e1c link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.3857%. Comparing base (d5dab77) to head (7690e1c).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58984        +/-   ##
================================================
+ Coverage   73.0522%   74.3857%   +1.3335%     
================================================
  Files          1682       1728        +46     
  Lines        465586     473807      +8221     
================================================
+ Hits         340121     352445     +12324     
+ Misses       104549      98955      -5594     
- Partials      20916      22407      +1491
Flag Coverage Δ
integration 46.3961% <ø> (?)
unit 72.2123% <100.0000%> (-0.0383%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.8883% <ø> (+15.5785%) ⬆️

tangenta
tangenta reviewed Jan 17, 2025
View reviewed changes
pkg/domain/infosync/info.go
@@ -912,6 +912,21 @@ func (is *InfoSyncer) updateTopologyAliveness(ctx context.Context) error {
clientv3.WithLease(is.topologySession.Lease()))
}

func (is *InfoSyncer) RemoveTopologyInfo() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported method InfoSyncer.RemoveTopologyInfo should have comment or be unexported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@ystaticy ystaticy ystaticy approved these changes

Assignees
No one assigned
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

domain ephemeral etcd keys should be cleanuped
4 participants
@iosmanthus @tangenta @hawkingrei @ystaticy