Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stmtctx: re-use the usedStatsInfo for different statements in a single session #59021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #59019

Problem Summary:

Previously, the data in usedStatsInfo is allocated for each statements. If we can re-use it across different statements in a session, it'll benefit the performance.

What changed and how does it work?

Use (*sync.Map).Clear() to reset the map, and assign the existing map to the new stmtctx.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 17, 2025
Copy link

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yangkeao, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2025
Signed-off-by: Yang Keao <[email protected]>
@YangKeao YangKeao force-pushed the accelerate-load-stats branch from a1160da to 69ff8ea Compare January 17, 2025 09:20
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3665%. Comparing base (889bf45) to head (69ff8ea).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59021        +/-   ##
================================================
+ Coverage   73.0236%   73.3665%   +0.3429%     
================================================
  Files          1684       1684                
  Lines        465663     466988      +1325     
================================================
+ Hits         340044     342613      +2569     
+ Misses       104708     103434      -1274     
- Partials      20911      20941        +30     
Flag Coverage Δ
integration 42.7732% <100.0000%> (?)
unit 72.2415% <100.0000%> (+0.0296%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.3155% <ø> (+0.0835%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't allocate the usedStatsInfo for each statements in a session
1 participant