Create ticker outside critical section

pion · Feb 7, 2024 · dfc49cb · dfc49cb
1 parent 5662268
commit dfc49cb
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/conn.go b/conn.go
@@ -166,10 +166,8 @@ func (c *Conn) Query(ctx context.Context, name string) (dnsmessage.ResourceHeade
 	query := &query{nameWithSuffix, queryChan}
 	c.mu.Lock()
 	c.queries = append(c.queries, query)
-	ticker := time.NewTicker(c.queryInterval)
 	c.mu.Unlock()
 
-	defer ticker.Stop()
 	defer func() {
 		c.mu.Lock()
 		defer c.mu.Unlock()
@@ -180,6 +178,9 @@ func (c *Conn) Query(ctx context.Context, name string) (dnsmessage.ResourceHeade
 		}
 	}()
 
+	ticker := time.NewTicker(c.queryInterval)
+	defer ticker.Stop()
+
 	c.sendQuestion(nameWithSuffix)
 	for {
 		select {