limit read buffer size to 9000B #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @sukunrt LGTM! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 63.70% 64.08% +0.38%
==========================================
Files 1 1
Lines 281 284 +3
==========================================
+ Hits 179 182 +3
Misses 72 72
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
net.Interfaces() contains the loop back interface whose MTU is 65kB. The RFC has a stricter limit of 9000 bytes. This saves us some space.
Sean-Der
force-pushed
the
reduce-buf-size
branch
from
9b9c7c6 to
d51aa08
Compare
Sean-Der
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net.Interfaces() contains the loop back interface whose MTU is 65kB. The RFC has a stricter limit of 9000 bytes. This saves us some space.
Ideally ice agents in pion/ice would share a single mdns connection but that's a much larger change that we can take up later and save us more space.