Support unicast query and answer #176
Conversation
|
Blocked on #173 |
edaniels
force-pushed
the
unicast_support
branch
from
e9fa688 to
f593090
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 60.92% 62.14% +1.22%
==========================================
Files 1 1
Lines 412 597 +185
==========================================
+ Hits 251 371 +120
- Misses 125 170 +45
- Partials 36 56 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edaniels
force-pushed
the
unicast_support
branch
3 times, most recently
from
f56a681 to
f1ac998
Compare
| for i := 0; i < numReaders; i++ { | ||
| <-readerStarted | ||
| } |
There was a problem hiding this comment.
Could achieve something similar with sync.waitGroup
There was a problem hiding this comment.
so I was thinking that but didn't feel like bothering with the race condition panics around waitgroups
|
Also, should consider adding additional unit tests |
edaniels
force-pushed
the
unicast_support
branch
from
f1ac998 to
7bc4c3a
Compare
edaniels
force-pushed
the
unicast_support
branch
from
278c137 to
6b73f8d
Compare
|
I'd love to add more unit tests, but I'm not really sure how to do that succinctly without getting very in the weeds with capturing the DNS packets or injecting in the unicast sockets. I'm open to suggestions for future PRs though! |
This also ends up internally supporting a good chunk of IPv6