Support IPv6 question and response #177
Conversation
edaniels
commented
Feb 8, 2024
edaniels
commented
- Addresses IPv6 support #69
|
pion/ice will need to figure how to consume this properly. It's not clear to me that it can/should just start adding an ipv6 packetconn to the server config |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
=============================
=============================
☔ View full report in Codecov by Sentry. |
config.go
Outdated
| @@ -38,4 +49,8 @@ type Config struct { | |||
|
|
|||
| // Interfaces will override the interfaces used for queries and answers. | |||
| Interfaces []net.Interface | |||
|
|
|||
| // MulticastConnV6 is used to receive mDNS questions over IPv6. It can be used in conjunction | |||
There was a problem hiding this comment.
This is arguably funky not being part of Server but it lets us not break the API for now
There was a problem hiding this comment.
@edaniels I think it is ok to break the API! Users are pretty low https://pkg.go.dev/github.com/pion/mdns?tab=importedby
edaniels
force-pushed
the
ipv6_support
branch
from
b424c7b to
2b41bfa
Compare
edaniels
force-pushed
the
ipv6_support
branch
from
2b41bfa to
9808cab
Compare
edaniels
force-pushed
the
ipv6_support
branch
3 times, most recently
from
5b55d64 to
c892668
Compare
- Addresses pion#69
edaniels
force-pushed
the
ipv6_support
branch
from
c892668 to
01c9c76
Compare
