Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dig based unicast requests #178

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Feb 9, 2024

e.g. dig -p 5353 @224.0.0.251 pion-test.local

Description

I noticed this wasn't supported after getting IPv6/unicast support in. The basic issue was 1. not using the ID that the question came from in the answer and 2. not supporting legacy resolvers (technically like ourselves as a non-continuous querier)

e.g. dig -p 5353 @224.0.0.251 pion-test.local
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (23c33ce) 67.50% compared to head (70b6f53) 66.75%.

Files Patch % Lines
conn.go 53.57% 8 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   67.50%   66.75%   -0.75%     
==========================================
  Files           1        1              
  Lines         717      737      +20     
==========================================
+ Hits          484      492       +8     
- Misses        165      173       +8     
- Partials       68       72       +4     
Flag Coverage Δ
go 66.75% <53.57%> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels merged commit 7c8d1a0 into pion:master Feb 9, 2024
11 of 13 checks passed
@edaniels edaniels deleted the support_dig branch February 9, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant