Improve IPv6 support #180
Merged
Improve IPv6 support #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
commented
Mar 25, 2024
edaniels
commented
Mar 25, 2024
| return | ||
| } | ||
|
|
||
| resultAddr := *addr | ||
| // DNS records don't contain IPv6 zones. |
There was a problem hiding this comment.
Calling this out as being important to getting the properly attributed zone back
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 67.30% 64.92% -2.38%
==========================================
Files 1 1
Lines 734 824 +90
==========================================
+ Hits 494 535 +41
- Misses 171 210 +39
- Partials 69 79 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This adds Server.QueryAddr for netip.Addr support
Sean-Der
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds Server.QueryAddr for netip.Addr support