-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement av1 depacketizer #291
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
==========================================
+ Coverage 85.18% 85.89% +0.70%
==========================================
Files 25 26 +1
Lines 2788 2913 +125
==========================================
+ Hits 2375 2502 +127
+ Misses 354 352 -2
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8b89a92
to
56225d1
Compare
@JoeTurki I am in support of merging and testing + improving after! The faster others can use it the sooner we get good feedback I saw the GStreamer devs point out some pion bugs. I bet if you @ them they would be willing to test. |
Thank you so much for doing this. So much complexity I was feeling intimidated by it |
I just want to set a real integration test to make sure then we good :) I'm just not sure about
Yeah I self assigned that Issue :) I didn't know that they will be willing to help, I played with that a bit last month, and it's on my todo list for the packetizer fix, I'll make the PR after this :) |
56225d1
to
51b8061
Compare
@Sean-Der hello this is ready now, it now reconstruct the OBUs with obu_size, I tested it with this pion/webrtc#3041 and ffplay, btw the jsfiddle in the |
Amazing work @JoeTurki I can't edit the jsfiddle :( mind just making a new one? Do you have a LinkedIn yet? If not you should post about this (and I can re-share it). Best way to find work in the future :) |
Adds AV1Depacketizer which implements the Depacketizer interface for AV1
51b8061
to
48e175c
Compare
@Sean-Der I added more tests mainly around non-standard packets (packets with obu_size) to make sure we get valid packets. Thank you, I'll post about it after the packetizer, Been testing it, I need to write a lot of tests, I'll make the PR today or tomorrow. Also I'll fix the jsfiddle and the AV1 examples after that. |
Description
Adds AV1Depacketizer which implements the Depacketizer interface for AV1
NOTE: I believe this meets the spec, but I'm unsure how it will interact with the sample builder. I’ve only tested it in Chrome, where it seems to work, but I need to conduct more thorough testing before we merge. I'll set up a test environment for AV1 with different encoders and clients, run end-to-end tests on Pion, and also fix the AV1 Packetizer (I have a list of a few bugs to address).
Reference issue
#189