Refactor H264Payloader to allow the deactivation of STAP-A packets. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-Der
reviewed
Feb 13, 2025
|
LGTM @YannSc! Mind exposing the field (instead of using a method) and we can get this merged :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 84.69% 84.72% +0.02%
==========================================
Files 24 24
Lines 2699 2703 +4
==========================================
+ Hits 2286 2290 +4
Misses 354 354
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Changed as requested. Thank you for the review ! |
…ALUs of type 7 (SPS) and type 8 (PPS) will be packed as Single NAL Units if STAP-A are disabled. This change can help to support packetization-mode=0 (single NALUs) in compliance with RFC6184.
Sean-Der
force-pushed
the
evol_h264_packet_stapa_disable
branch
from
e2c3e61 to
50b323b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a field* to disable the creation of
STAP-Apackets by the H264Payloader.STAP-Apackets are created by default.STAP-Apackets is disabled, NALUs of type 7 (SPS) and type 8 (PPS) will be packed as Single NAL Units.This change can be a step to support
packetization-mode=0(single NALUs) in compliance with RFC6184.Reference issue
This change is related to bluenviron/gortsplib#585
Context and use case
The use case motivating this change is to simulate a proprietary piece of hardware. This hardware shows limited RTP packetization capabilities as it does not generate
STAP-Apackets (only single NALUs and FUas).Thanks,