Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade linters #2985

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Upgrade linters #2985

merged 1 commit into from
Jan 18, 2025

Conversation

joeturki
Copy link
Member

@joeturki joeturki commented Jan 2, 2025

Description

Upgrade the linters, I will ignore those that require refactor (will be addressed in a separate PR).

Reference PR

pion/.goassets#220

@joeturki joeturki mentioned this pull request Jan 2, 2025
20 tasks
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 89.29664% with 105 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (99dcc6b) to head (feeeebf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
peerconnection.go 91.00% 17 Missing and 9 partials ⚠️
sdp.go 90.15% 9 Missing and 4 partials ⚠️
interceptor.go 55.55% 8 Missing and 4 partials ⚠️
rtpreceiver.go 83.72% 4 Missing and 3 partials ⚠️
dtlstransport.go 82.85% 6 Missing ⚠️
pkg/media/ivfwriter/ivfwriter.go 50.00% 5 Missing ⚠️
pkg/media/oggwriter/oggwriter.go 73.68% 5 Missing ⚠️
datachannel.go 81.81% 4 Missing ⚠️
icegatherer.go 76.92% 3 Missing ⚠️
icetransport.go 83.33% 1 Missing and 2 partials ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2985      +/-   ##
==========================================
+ Coverage   78.00%   78.47%   +0.46%     
==========================================
  Files          89       89              
  Lines       10582    11037     +455     
==========================================
+ Hits         8255     8661     +406     
- Misses       1838     1890      +52     
+ Partials      489      486       -3     
Flag Coverage Δ
go 80.01% <89.29%> (+0.43%) ⬆️
wasm 63.61% <74.74%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iceserver_test.go Outdated Show resolved Hide resolved
@Sean-Der
Copy link
Member

Sean-Der commented Jan 2, 2025

Amazing! This is exactly what we need @joeturki

If you are overwhelmed by the lints you can just upgrade versions/disable more and we can iterate on it!

.golangci.yml Outdated Show resolved Hide resolved
@joeturki joeturki marked this pull request as draft January 17, 2025 16:39
Introduces new linters, upgrade golangci-lint to version (v1.63.4)
@joeturki joeturki marked this pull request as ready for review January 18, 2025 13:18
@joeturki joeturki merged commit feeeebf into master Jan 18, 2025
18 checks passed
@joeturki joeturki deleted the impr/basic-lint branch January 18, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants