-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade linters #2985
Upgrade linters #2985
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2985 +/- ##
==========================================
+ Coverage 78.00% 78.47% +0.46%
==========================================
Files 89 89
Lines 10582 11037 +455
==========================================
+ Hits 8255 8661 +406
- Misses 1838 1890 +52
+ Partials 489 486 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Amazing! This is exactly what we need @joeturki If you are overwhelmed by the lints you can just upgrade versions/disable more and we can iterate on it! |
875f2bb
to
37cc0f4
Compare
Introduces new linters, upgrade golangci-lint to version (v1.63.4)
b5559ee
to
feeeebf
Compare
Description
Upgrade the linters, I will ignore those that require refactor (will be addressed in a separate PR).
Reference PR
pion/.goassets#220