feat: implement js,wasm DataChannel OnError & OnClosing #3030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FYI
OnClosing
is not implemented in the non-JS version of Pion,so this is a JS-only method. Please consider if this is a good idea.
This is a follow-up to #479.
FYI I have not tested the
OnError
event (in particular obtainingerrorMessage
), but the both methods are largely copy-pasted from similar ones.Reference issue
Partially addresses #519 (comment).
If I may, @albrow thank you so much for the initial implementation!
It's a bliss that it "just works"!