Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetRemoteParameters to ICETransport #3038

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

Sean-Der
Copy link
Member

Exists in webrtc-pc, we just haven't implemented it yet

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (969ab68) to head (7751727).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
icetransport.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3038      +/-   ##
==========================================
+ Coverage   78.36%   78.38%   +0.01%     
==========================================
  Files          91       91              
  Lines       11234    11250      +16     
==========================================
+ Hits         8804     8818      +14     
  Misses       1940     1940              
- Partials      490      492       +2     
Flag Coverage Δ
go 80.25% <81.25%> (+0.01%) ⬆️
wasm 63.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Exists in webrtc-pc, we just haven't implemented it yet
@Sean-Der Sean-Der force-pushed the get-remote-params-icetransport branch from 17c3c64 to 7751727 Compare February 17, 2025 18:34
@Sean-Der Sean-Der merged commit 70f0211 into master Feb 17, 2025
18 checks passed
@Sean-Der Sean-Der deleted the get-remote-params-icetransport branch February 17, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants