-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a means to optionally defer function call completion #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2828f7c
to
1ca6ecc
Compare
aconchillo
approved these changes
Jan 13, 2025
LGTM! |
Hey @markbackman thanks for pushing this improvement. Quick feedback that it seems to break function calling for openai realtime pipelines:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
This was motivated by the following Flows issue: pipecat-ai/pipecat-flows#67
The issue is that two consecutive completions occurs in Flows: one for the function call completing and one for the subsequent node's message. This change adds the flexibility to defer the completion for a function call. For the Flows case, this will allow a completion to occur after both the function call and the node's message are added to the context.
This maintains backwards compatibility and attempts to avoid complexity. I'm open to suggestions of different ways to accomplish this. In my testing, this works for Flows and maintains backwards compatibility.