Align 26d example with foundation norms #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Jan 12, 2025
| ) | ||
| from pipecat.transports.services.daily import DailyParams, DailyTransport | ||
|
|
||
| load_dotenv(override=True) | ||
|
|
||
| logger.remove(0) | ||
| logger.add(sys.stderr, level="DEBUG") | ||
| logger.add("app.log", rotation="500 MB", level="TRACE") | ||
| logger.add(sys.stderr, level="TRACE") |
There was a problem hiding this comment.
Why do we need TRACE? It's very verbose.
There was a problem hiding this comment.
Oops, that was left over from debugging. Just removed it. Thanks for catching it.
markbackman
force-pushed
the
mb/26d-example
branch
from
67c1fee to
f406d93
Compare
aconchillo
approved these changes
Jan 13, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
Just some minor changes to bring this in line with other examples.