Fixes around attaching volumes with unusual resources #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diskless flag is used to indicate the type of diskless resource LINSTOR should create. This is determined by the available layers in the resource. If there is no DRBD or NVMe layer, diskless attachment does not make sense, so we error out in that case. Signed-off-by: Moritz Wanzenböck <[email protected]>
Signed-off-by: Moritz Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
fix-unusual-layers-with-diskless
branch
from
d476d0f to
0f3a74c
Compare
if a user creates a resource without replication, it does not make sense to access it from anywhere but the local node. So we set the default access policy accordingly. Signed-off-by: Moritz Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
fix-unusual-layers-with-diskless
branch
from
0f3a74c to
10a2f0a
Compare
WanzenBug
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues in the AttachVolume call and beyond: