disable fallback to RO mounts for RW volumes #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user requests a RW volume, we disable the default behaviour of "mount" to fallback to RO mounts should there be an issue with the initial RW attempt. This may happen if a DRBD device is in a weird state, where the default auto-promote does not succeed, but the resource is otherwise fine. A RO mount does not require an explicit state change, so it may succeed in such a situation. By requesting "rw" in the mount options, we prevent this behaviour. Signed-off-by: Moritz Wanzenböck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user requests a RW volume, we disable the default behaviour of "mount" to fallback to RO mounts should there be an issue with the initial RW attempt.
This may happen if a DRBD device is in a weird state, where the default auto-promote does not succeed, but the resource is otherwise fine. A RO mount does not require an explicit state change, so it may succeed in such a situation.
By requesting "rw" in the mount options, we prevent this behaviour.