Skip to content

Commit

Permalink
chart: fix CSI values
Browse files Browse the repository at this point in the history
Some chart values where not applied correctly, either using
the wrong names or wrong filters that lead to errors.

While the names used originally in the CR where much clearer, we
don't want to introduce a breaking change, so we keep them as is.

We also don't change the helm names, as they are much more descriptive,
at the cost of some potential minor confusion. This should be fine, as
nobody noticed this issue until now, and probably never will.

Signed-off-by: Moritz "WanzenBug" Wanzenböck <[email protected]>
  • Loading branch information
WanzenBug authored and JoelColledge committed Nov 20, 2023
1 parent 6a67907 commit acc8084
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions charts/piraeus/templates/operator-csi-driver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
priorityClassName: {{ .Values.priorityClassName | default "" | quote }}
controllerReplicas: {{ .Values.csi.controllerReplicas }}
{{- if .Values.csi.controllerStrategy }}
controllerStrategy: {{ .Values.csi.controllerStrategy }}
controllerStrategy: {{ .Values.csi.controllerStrategy | toJson}}
{{- end }}
controllerEndpoint: {{ template "controller.endpoint" . }}
nodeAffinity: {{ .Values.csi.nodeAffinity | toJson }}
Expand All @@ -61,10 +61,10 @@ spec:
logLevel: {{ .Values.csi.logLevel | quote }}
{{- end }}
{{- if .Values.csi.controllerSidecars }}
controllerSidecars: {{ .Values.csi.controllerSidecars | toJson }}
sidecars: {{ .Values.csi.controllerSidecars | toJson }}
{{- end }}
{{- if .Values.csi.controllerExtraVolumes }}
controllerExtraVolumes: {{ .Values.csi.controllerExtraVolumes | toJson }}
extraVolumes: {{ .Values.csi.controllerExtraVolumes | toJson }}
{{- end }}
{{- if .Values.csi.nodeSidecars }}
nodeSidecars: {{ .Values.csi.nodeSidecars | toJson }}
Expand Down

0 comments on commit acc8084

Please sign in to comment.