Support complex node affinity in cluster spec #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
complex-affinity
branch
3 times, most recently
from
84ea408 to
fa32114
Compare
WanzenBug
force-pushed
the
complex-affinity
branch
from
fa32114 to
0f3b0bc
Compare
|
|
||
| Selects which nodes the LinstorSatelliteConfiguration should apply to. If empty, the configuration applies to all nodes. | ||
|
|
||
| When this is used together with `.spec.nodeAffinity`, both need to match in order for the configuration to apply to a |
There was a problem hiding this comment.
Suggested change
| When this is used together with `.spec.nodeAffinity`, both need to match in order for the configuration to apply to a | |
| When this is used together with `.spec.nodeSelector`, both need to match in order for the configuration to apply to a |
|
The rest all looks good 👍 |
Use the nodeAffinity, like one would set it on pods to allow more complex deployment scenarios. We need to respect these settings when creating Satellites, but also when creating our own deployments. For consistency, the same options are also available on sht satellite configuration resources. Signed-off-by: Moritz "WanzenBug" Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
complex-affinity
branch
from
0f3b0bc to
425b2ec
Compare
JoelColledge
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the nodeAffinity, like one would set it on pods to allow more complex deployment scenarios. We need to respect these settings when creating Satellites, but also when creating our own deployments.
Fixes #522