Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix udev sync in containers #179

Merged
merged 1 commit into from
Apr 4, 2024
Merged

docker: fix udev sync in containers #179

merged 1 commit into from
Apr 4, 2024

Conversation

WanzenBug
Copy link
Member

Next operator release mounts /run/udev into the container because that is needed to get ZFS working. However, this had the side effect of breaking LVM.

LVM is by default checking for the existence of this directory to determine if it should wait for udev events. This is however broken inside containers, so the LVM commands all time out, breaking LINSTOR with weird errors all around.

To fix this, disable the "udev_sync", so LVM no longer waits on udev events.

@WanzenBug WanzenBug requested a review from rck April 4, 2024 08:53
Next operator release mounts /run/udev into the container because that is
needed to get ZFS working. However, this had the side effect of breaking LVM.

LVM is by default checking for the existence of this directory to determine if
it should wait for udev events. This is however broken inside containers, so
the LVM commands all time out, breaking LINSTOR with weird errors all around.

To fix this, disable the "udev_sync", so LVM no longer waits on udev events.

Signed-off-by: Moritz Wanzenböck <[email protected]>
Copy link
Member

@rck rck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess that is fine here. do we intend to "backport" that for our customer containers? what about rhel8 they are still based on?

@WanzenBug
Copy link
Member Author

do we intend to "backport" that for our customer containers?

I intend to backport it to the 1.27.0 containers, as those will be the ones shipped with the operator version.

@WanzenBug WanzenBug merged commit 9ceb5a0 into master Apr 4, 2024
2 checks passed
@WanzenBug WanzenBug deleted the fix-udev branch April 4, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants