Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: use common base image #193

Merged
merged 1 commit into from
Sep 26, 2024
Merged

docker: use common base image #193

merged 1 commit into from
Sep 26, 2024

Conversation

WanzenBug
Copy link
Member

In order to configure the LINBIT repositories, we need to install the linbit-keyring package. This requires some set up as we need to fetch the package and then set up the repositories.

To make this nicer to work with, we use a single base docker image as the root of all builds.

While at it, also make use of proper tmpfs and cache mounts, so we do not add unnecessary files into the image layers.

In order to configure the LINBIT repositories, we need to install the
linbit-keyring package. This requires some set up as we need to fetch the
package and then set up the repositories.

To make this nicer to work with, we use a single base docker image as the root
of all builds.

While at it, also make use of proper tmpfs and cache mounts, so we do not add
unnecessary files into the image layers.

Signed-off-by: Moritz Wanzenböck <[email protected]>
@WanzenBug WanzenBug requested a review from rck September 26, 2024 09:37
@WanzenBug WanzenBug mentioned this pull request Sep 26, 2024
Copy link
Member

@rck rck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rck rck merged commit 547bb82 into master Sep 26, 2024
2 checks passed
@rck rck deleted the linbit-keyring branch September 26, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants