Check ADTS frame len and UDP frame len match to stop invalid data output #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packets with the correct header (0xFF 0xF9/0xFF 0xF1) aren't actually valid AAC ADTS frames in some streams (e.g. Hispasat 30W 12518H). We can filter these by checking that the UDP packet length for the payload (minus headers) matches the packet length as reported in the ADTS frames itself.
The invalid ADTS frames have super long length values (e.g. 7831 bytes), which doesn't match the spec (max frame length 768 bytes), so these seem safe to drop. I don't know what these invalid frames are and what purpose they serve, but I've tested this fix with the Hispasat streams and the output AAC data is glitch-free and plays perfectly.
Fixes #36