BUGFIX: Ignores non-configurable properties when associating existing collection item GUIDs #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
kcboyle
reviewed
Aug 27, 2020
| @@ -115,6 +115,9 @@ func (item responsePropertyCollectionItem) getFieldValuesExceptGUID() map[interf | |||
| if key == "guid" { | |||
| continue | |||
| } | |||
| if !valueObj.(map[interface{}]interface{})["configurable"].(bool) { | |||
There was a problem hiding this comment.
In terms of readability, the only think I would change is pulling out !valueObj.(map[interface{}]interface{})["configurable"].(bool) into
isNotConfigurable = valueObj.(map[interface{}]interface{})["configurable"].(bool)
if isNotConfigurable {
continue
}
|
I think this looks great. I'd be happy to pull it in. CI failures are due to things not in your control |
mrdavidlaing
force-pushed
the
ignore_non_configurable_properties_in_collections_when_associating_guids
branch
from
383878d to
58f67d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug (related to #207) where new GUIDs were being assigned for collection items that contained non-configurable properties even though non of the values had changed