Handle collections containing secrets when finding existing property GUIDs #505
Conversation
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
| @@ -137,12 +156,20 @@ func (existingCollection responsePropertyCollection) findGUIDForEquivalentlItem( | |||
| return "", false | |||
| } | |||
|
|
|||
| func associateExistingCollectionGUIDs(updatedProperty interface{}, existingProperty ResponseProperty) error { | |||
| updatedCollection, err := parseUpdatedPropertyCollection(updatedProperty) | |||
| type associateExistingCollectionGUIDsInput struct { | |||
There was a problem hiding this comment.
Most of the changes are a result of this refactoring, implemented to make passing the properties needed to enable func parseResponsePropertyCollection() to make a Api.GetDeployedProductCredential() call to fetch the existing secret values
| for collectionItemKey, collectionItemObj := range itemMap { | ||
| collectionItemObjAsMap := collectionItemObj.(map[interface{}]interface{}) | ||
| isCredential := collectionItemObjAsMap["credential"].(bool) | ||
| if !isCredential { | ||
| continue | ||
| } | ||
|
|
||
| credentialName := fmt.Sprintf("%s[%d].%s", input.PropertyName, index, collectionItemKey) | ||
| apiOutput, err := input.APIService.GetDeployedProductCredential(GetDeployedProductCredentialInput{ | ||
| DeployedGUID: input.ProductGUID, | ||
| CredentialReference: credentialName, | ||
| }) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| collectionItemObjAsMap["value"] = apiOutput.Credential.Value | ||
| } |
There was a problem hiding this comment.
Fetching the credential values like this increases the HTTP requests made by
om configure-product --config example-product.config.yml
from 40 to 60
There was a problem hiding this comment.
is it going to be 60 requests every time, or just for collection objects?
There was a problem hiding this comment.
not too worried about the time addition
|
It looks like there's a merge conflict in |
Addresses one of the known issues for collection GUID assignment addressed in #207: