Hardening suggestions for codemodder-python / report-token-usage #992
+85
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
| @@ -89,8 +89,7 @@ def apply_codemods( | |||
| for codemod in codemods_to_run: | |||
| # NOTE: this may be used as a progress indicator by upstream tools | |||
| logger.info("running codemod %s", codemod.id) | |||
| codemod_token_usage = codemod.apply(context) | |||
| if codemod_token_usage: | |||
| if codemod_token_usage := codemod.apply(context): | |||
There was a problem hiding this comment.
Replaces multiple expressions involving if operator with 'walrus' operator.
pixeebot
bot
force-pushed
the
pixeebot/report-token-usage
branch
from
3b58431 to
d3d4df7
Compare
pixeebot
bot
force-pushed
the
pixeebot/report-token-usage
branch
from
94865c4 to
9d394d0
Compare
|
clavedeluna
force-pushed
the
report-token-usage
branch
from
1a1594a to
aa35ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (991 - Report LLM token usage) and have identified some area(s) that could benefit from additional hardening measures.
These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
🧚🤖 Powered by Pixeebot
Feedback | Community | Docs