fix review comments

pixel-point · Feb 4, 2025 · 0e2d371 · 0e2d371
1 parent f97da3a
commit 0e2d371
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 17 deletions.
diff --git a/apps/gitness/src/routes.tsx b/apps/gitness/src/routes.tsx
@@ -28,15 +28,15 @@ import { ProjectLabelsList } from './pages-v2/project/labels/project-labels-list
 import { ProjectGeneralSettingsPageContainer } from './pages-v2/project/project-general-settings-container'
 import { ImportProjectContainer } from './pages-v2/project/project-import-container'
 import { ProjectMemberListPage } from './pages-v2/project/project-member-list'
-import { ProjectSettingsLayout } from './pages-v2/project/project-settings-layout.tsx'
+import { ProjectSettingsLayout } from './pages-v2/project/project-settings-layout'
 import PullRequestChanges from './pages-v2/pull-request/pull-request-changes'
 import { PullRequestCommitPage } from './pages-v2/pull-request/pull-request-commits'
 import { CreatePullRequest } from './pages-v2/pull-request/pull-request-compare'
 import PullRequestConversationPage from './pages-v2/pull-request/pull-request-conversation'
 import PullRequestDataProvider from './pages-v2/pull-request/pull-request-data-provider'
 import PullRequestLayout from './pages-v2/pull-request/pull-request-layout'
 import PullRequestListPage from './pages-v2/pull-request/pull-request-list'
-import { RepoLabelFormContainer } from './pages-v2/repo/labels/label-form-container.tsx'
+import { RepoLabelFormContainer } from './pages-v2/repo/labels/label-form-container'
 import { RepoLabelsList } from './pages-v2/repo/labels/labels-list-container'
 import { RepoBranchesListPage } from './pages-v2/repo/repo-branch-list'
 import { RepoBranchSettingsRulesPageContainer } from './pages-v2/repo/repo-branch-rules-container'

diff --git a/packages/ui/src/components/alert/AlertContainer.tsx b/packages/ui/src/components/alert/AlertContainer.tsx
@@ -48,7 +48,7 @@ export const AlertContainer = forwardRef<HTMLDivElement, AlertContainerProps>(
         {closable && (
           <button
             type="button"
-            className="absolute top-2 right-2 text-gray-400 hover:text-gray-500"
+            className="absolute right-2 top-2 text-gray-400 hover:text-gray-500"
             onClick={() => setIsVisible(false)}
           >
             <Icon name="close" size={16} />

diff --git a/packages/ui/src/components/tabs.tsx b/packages/ui/src/components/tabs.tsx
@@ -33,9 +33,9 @@ const tabsTriggerVariants = cva(
         underline:
           'm-0 h-11 border-b-2 border-solid border-b-transparent px-0 font-normal data-[state=active]:border-primary',
         navigation:
-          'm-0 my-1 h-9 px-0 font-normal text-foreground-2 duration-150 ease-in-out after:absolute after:inset-[-0.25rem_0] after:block after:border-b after:border-solid after:border-b-transparent hover:text-foreground-1 data-[state=active]:after:border-borders-9',
+          'm-0 my-1 h-9 px-0 text-13 font-normal leading-none text-foreground-2 duration-150 ease-in-out after:absolute after:inset-[-0.25rem_0] after:block after:border-b after:border-solid after:border-b-transparent hover:text-foreground-1 data-[state=active]:after:border-borders-9',
         tabnav:
-          'h-9 rounded-t-md border-x border-t border-transparent px-4 font-normal text-foreground-2 hover:text-foreground-1 data-[state=active]:border-borders-1 data-[state=active]:bg-background-1 data-[state=active]:text-foreground-1'
+          'h-9 rounded-t-md border-x border-t border-transparent px-4 font-normal text-foreground-2 hover:text-foreground-1 data-[state=active]:border-borders-1 data-[state=active]:bg-background-1'
       }
     },
     defaultVariants: {

diff --git a/packages/ui/src/views/execution/console-logs.tsx b/packages/ui/src/views/execution/console-logs.tsx
@@ -63,14 +63,14 @@ const ConsoleLogs: FC<ConsoleLogsProps> = ({ logs, query }) => {
           <div className="mb-2 flex items-baseline justify-between leading-[21px]" key={index}>
             <div className="flex items-baseline gap-2">
               {pos !== undefined && !isNaN(pos) && pos >= 0 && (
-                <Text className="flex min-w-5 justify-end text-log">{pos}</Text>
+                <Text className="text-log flex min-w-5 justify-end">{pos}</Text>
               )}
               {time ? (
-                <Text className="flex text-sm font-normal text-log">[{formatTimestamp(time * 1_000)}]</Text>
+                <Text className="text-log flex text-sm font-normal">[{formatTimestamp(time * 1_000)}]</Text>
               ) : null}
               {out ? logText(out) : null}
             </div>
-            <Text className="mr-2 text-sm font-normal text-log">
+            <Text className="text-log mr-2 text-sm font-normal">
               {formatDuration(duration && duration > 0 ? duration * 1_000 : 0)}
             </Text>
           </div>

diff --git a/packages/ui/src/views/execution/execution-header.tsx b/packages/ui/src/views/execution/execution-header.tsx
@@ -46,7 +46,7 @@ export const ExecutionHeader: React.FC<ExecutionHeaderProps> = ({
           <span className="text-primary">{title.title}</span>
         </Text>
       </div>
-      <div className="flex items-end gap-12 h-full">
+      <div className="flex h-full items-end gap-12">
         <div className="flex flex-col">
           <span className="text-foreground-5">Storage</span>
           <span className="text-primary">{storage}</span>

diff --git a/packages/ui/src/views/execution/execution-status.tsx b/packages/ui/src/views/execution/execution-status.tsx
@@ -26,7 +26,7 @@ const Badge: React.FC<ExecutionStatusProps & BadgeProps> = props => {
     case ExecutionState.RUNNING:
       return minimal ? (
         <div className="flex items-center gap-1">
-          <div className="size-2 rounded-full bg-studio-3" />
+          <div className="bg-studio-3 size-2 rounded-full" />
           <span className="text-studio-3">Running</span>
         </div>
       ) : (

diff --git a/packages/ui/src/views/execution/key-value-table.tsx b/packages/ui/src/views/execution/key-value-table.tsx
@@ -20,12 +20,12 @@ export const KeyValueTable: React.FC<KeyValueTableProps> = ({
       if (typeof item.value === 'string') {
         return (
           <ul className="flex flex-row border-b align-middle" key={index}>
-            <li className="w-1/2 py-2.5 pr-2.5 text-studio-7" style={{ paddingLeft: `${level + 1}rem` }}>
+            <li className="text-studio-7 w-1/2 py-2.5 pr-2.5" style={{ paddingLeft: `${level + 1}rem` }}>
               <Text size={2} weight="normal">
                 {item.name}
               </Text>
             </li>
-            <li className="w-1/2 py-2.5 pl-1.5 pr-2.5 text-studio-7">
+            <li className="text-studio-7 w-1/2 py-2.5 pl-1.5 pr-2.5">
               <Text size={2} weight="normal">
                 {item.value}
               </Text>

diff --git a/packages/ui/src/views/execution/pipeline-status.tsx b/packages/ui/src/views/execution/pipeline-status.tsx
@@ -14,7 +14,7 @@ export const PipelineStatus = ({
   createdTime: string
 }) => {
   return (
-    <div className="flex justify-between pl-6 pr-6 pt-3 pb-4 border-b">
+    <div className="flex justify-between border-b px-6 pb-4 pt-3">
       <div className="flex flex-col">
         <span className="text-foreground-5">Status</span>
         <ExecutionStatus.Badge status={status} />

diff --git a/packages/ui/src/views/execution/step-execution.tsx b/packages/ui/src/views/execution/step-execution.tsx
@@ -69,7 +69,7 @@ export const StepExecution: React.FC<StepExecutionProps> = ({ step, logs, onEdit
           />
         </Layout.Horizontal>
         <TabsContent value={StepExecutionTab.LOG}>
-          <ScrollArea className="h-[calc(100vh-23rem)] border-t pt-4 px-2">
+          <ScrollArea className="h-[calc(100vh-23rem)] border-t px-2 pt-4">
             <ConsoleLogs logs={logs} query={query} />
           </ScrollArea>
         </TabsContent>

diff --git a/packages/ui/src/views/repo/webhooks/webhook-executions/repo-webhook-executions-page.tsx b/packages/ui/src/views/repo/webhooks/webhook-executions/repo-webhook-executions-page.tsx
@@ -42,14 +42,14 @@ const RepoWebhookExecutionsPage: FC<RepoWebhookExecutionsPageProps> = ({
 
   return (
     <SandboxLayout.Main className="mx-0">
-      <SandboxLayout.Content className="pl-0 max-w-[812px]">
-        <h1 className="text-2xl font-medium text-foreground-1 mb-4">Order Status Update Webhook</h1>
+      <SandboxLayout.Content className="max-w-[812px] pl-0">
+        <h1 className="mb-4 text-2xl font-medium text-foreground-1">Order Status Update Webhook</h1>
         <Text>
           This webhook triggers every time an order status is updated, sending data to the specified endpoint for
           real-time tracking.
         </Text>
         <FormSeparator className="my-6" />
-        <h1 className="text-xl font-medium text-foreground-1 mb-4">Executions</h1>
+        <h1 className="mb-4 text-xl font-medium text-foreground-1">Executions</h1>
         {isLoading ? (
           <SkeletonList />
         ) : executions && executions.length > 0 ? (