Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable launch at login #2

Closed
wants to merge 2 commits into from
Closed

Enable launch at login #2

wants to merge 2 commits into from

Conversation

rodionovd
Copy link

@rodionovd rodionovd commented Jun 17, 2017

This PR brings a proper support for "launch at login" feature by binding the corresponding checkbox to a middleware controller object.

@@ -28,16 +27,6 @@ - (void)applicationDidFinishLaunching:(NSNotification *)aNotification {

[NSTouchBarItem addSystemTrayItem:mute];
DFRElementSetControlStripPresenceForIdentifier(muteIdentifier, YES);

[self enableLoginAutostart];
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically enabling "launch at login" is very user-hostile and I wouldn't recommend doing it. Let the user decide for themselves.

Also, Apple won't allow this in Mac App Store if you ever going to publish there.

@lnikell
Copy link
Member

lnikell commented Jun 17, 2017

Thanks @rodionovd, but still does not work :) I used Product-Archieve-Export in Xcode, moved app to Application then opened it and set checkbox in true. Then restarted mac and unfortunately icon not appeared.

@rodionovd
Copy link
Author

@lnikell yep, it seems like your launcher app wasn't Sandboxed. Should be fixed now

@lnikell
Copy link
Member

lnikell commented Jun 17, 2017

@rodionovd unfortunately still no :(

@rodionovd
Copy link
Author

Well it definitely works for me when I export the app as "Developer ID" signed

@lnikell lnikell closed this Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants