Watch command not working

[Wazrop]

Hello,

When using watch flag with assetpack assetpack -w it throws and error RangeError: Maximum call stack size exceeded.

C:\assetpack-test> npm run watch-assets

> watch-assets
> assetpack -w

› Info: [AssetPack] cache found.                                                                                                                                                                                                                                                   
✔ AssetPack Initialized
› Building: C:/assetpack-test/raw-assets
|                                          | 0%C:\assetpack-test\node_modules\upath\build\code\upath.js:34
  p = p.replace(/(?<!^)\/+/g, "/");
        ^

RangeError: Maximum call stack size exceeded
    at String.replace (<anonymous>)
    at toUnix (C:\assetpack-test\node_modules\upath\build\code\upath.js:34:9)
    at C:\assetpack-test\node_modules\upath\build\code\upath.js:46:20
    at Array.map (<anonymous>)
    at Object.dirname (C:\assetpack-test\node_modules\upath\build\code\upath.js:44:21)
    at AssetWatcher._ensureDirectory (file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:196:33)
    at AssetWatcher._ensureDirectory (file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:200:14)
    at AssetWatcher._ensureDirectory (file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:200:14)
    at AssetWatcher._ensureDirectory (file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:200:14)
    at AssetWatcher._ensureDirectory (file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:200:14)

Node.js v22.1.0

package.json

{
  "type": "module",
  "scripts": {
    "assets": "assetpack",
    "watch-assets": "assetpack -w"
  },
  "devDependencies": {
    "@assetpack/core": "^1.1.1"
  }
}

.assetpack.js

export default {
  entry: "./raw-assets",
  output: "./public/assets",
  ignore: ["**/*.html"],
  cache: true,
  cacheLocation: ".assetpack",
  logLevel: "info",
};

[Zyie]

hmm I think this might be a windows specific issue

I don't have a windows machine right now, so are you able to change this line of code:

assetpack/packages/assetpack/src/core/AssetWatcher.ts

Line 307 in 8c64a16

if (parentPath === this._entryPath || parentPath === '.' || parentPath === '/')

to this:
if (parentPath === this._entryPath || parentPath === '.' || parentPath === '\\')

[Wazrop]

Tried it but the parentPath is always C:/ so I checked it against current path, like this:

if (parentPath === this._entryPath || parentPath === '.' || parentPath === dirPath)

It successfully goes out of the recursion but it dies when adding child:

PS C:\assetpack-test> npm run watch-assets

> watch-assets
> assetpack -w

› Info: [AssetPack] cache found.                                                                                                                                                                                                                                                                              
✔ AssetPack Initialized
› Building: C:/assetpack-test/raw-assets
|                                          | 0%test: C:\assetpack-test\raw-assets C:/assetpack-test
test: C:/assetpack-test C:/
test: C:/ C:/
file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:211
        parentAsset.addChild(asset);
                    ^

TypeError: Cannot read properties of undefined (reading 'addChild')
    at AssetWatcher._ensureDirectory (file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:211:21)
    at AssetWatcher._ensureDirectory (file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:201:14)
    at file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:130:22
    at Array.forEach (<anonymous>)
    at AssetWatcher._applyChangeToAssets (file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:120:17)
    at AssetWatcher._updateAssets (file:///C:/assetpack-test/node_modules/@assetpack/core/dist/core/AssetWatcher.js:114:14)

Node.js v22.1.0

[Zyie]

ok thank you for trying!
I should be able to test this on a windows machine later in the week, so will look into it then!