Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pixiPipes resolution options override #74

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Fire7
Copy link
Contributor

@Fire7 Fire7 commented Jul 30, 2024

this code

apConfig.resolutions ??= config?.resolutions;

always results in the merged value instead of the config value.

Copy link
Member

@Zyie Zyie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@Zyie Zyie merged commit c428b74 into pixijs:main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants