Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update to use named exports #401

Merged
merged 18 commits into from
Jan 19, 2024
Merged

Chore: update to use named exports #401

merged 18 commits into from
Jan 19, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Jan 17, 2024

The repo has now been updated to be a single repo with many named exports
I've also just simplified everything to use extension-scripts to make it match our other repos

So the new way to use the repo is import { x } from 'pixi-filters/displacement'

@Zyie Zyie changed the title Chore: update to use exports Chore: update to use named exports Jan 17, 2024
@bigtimebuddy
Copy link
Member

HERO! This is amazing. Will review and leave any notes

package.json Outdated Show resolved Hide resolved
@bigtimebuddy
Copy link
Member

@bigtimebuddy
Copy link
Member

@Zyie I'm seeing an issue here with the exports:

"./adjustment": {
      "import": "./lib/adjustment.mjs",
      "require": "./lib/adjustment.js",
      "types": "./lib/adjustment.d.ts"
},

Those paths don't exist:

Screen Shot 2024-01-18 at 2 03 51 PM

It doesn't look like Rollup generates the index.js/index.mjs files for each filter folder.

@bigtimebuddy
Copy link
Member

bigtimebuddy commented Jan 18, 2024

I think I found a solution to the exports but need to make a tweak to extension-scripts

Solved this by adding an explicit glob for moduleSource. See related Rollup issue here.

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the publishing workflow on actions still needs some work, but I'm happy with this.

@bigtimebuddy bigtimebuddy merged commit b360d40 into next-v8-webgl Jan 19, 2024
2 checks passed
@bigtimebuddy bigtimebuddy deleted the exports branch January 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants