Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Drop Shadow Filter Deprecations #422

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Chore: Drop Shadow Filter Deprecations #422

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9e5bec
Chore: Drop Shadow Filter Deprecations
bbazukun123 Feb 8, 2024
e850597
Merge branch 'main' into chore-deprecation-drop-shadow
bbazukun123 Feb 14, 2024
a3e1535
Cleanup
bbazukun123 Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions src/drop-shadow/DropShadowFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import source from './drop-shadow.wgsl';
export interface DropShadowFilterOptions
{
/**
* Set the offset position of the drop-shadow relative to the original image.
* The offset position of the drop-shadow relative to the original image.
* @default {x:4,y:4}
*/
offset?: PointData;
Expand Down Expand Up @@ -54,10 +54,15 @@ export interface DropShadowFilterOptions
*/
kernels?: number[];
/**
* Sets the pixelSize of the Kawase Blur filter
* The pixelSize of the Kawase Blur filter
* @default {x:1,y:1}
*/
pixelSize?: PointData;
pixelSize?: PointData | number[] | number;
/**
* The resolution of the Kawase Blur filter
* @default 1
*/
resolution?: number;
}

/**
Expand All @@ -79,6 +84,7 @@ export class DropShadowFilter extends Filter
blur: 2,
quality: 3,
pixelSize: { x: 1, y: 1 },
resolution: 1,
};

public uniforms: {
Expand Down Expand Up @@ -127,7 +133,8 @@ export class DropShadowFilter extends Filter
uColor: { value: new Float32Array(3), type: 'vec3<f32>' },
uOffset: { value: options.offset, type: 'vec2<f32>' },
}
}
},
resolution: options.resolution,
});

this.uniforms = this.resources.dropShadowUniforms.uniforms;
Expand Down Expand Up @@ -294,9 +301,19 @@ export class DropShadowFilter extends Filter
{
return this._blurFilter.pixelSize as PointData;
}
set pixelSize(value: PointData)
set pixelSize(value: PointData | number[] | number)
{
(this._blurFilter.pixelSize as PointData) = value;
if (typeof value === 'number')
{
value = { x: value, y: value };
}

if (Array.isArray(value))
{
value = { x: value[0], y: value[1] };
}

this._blurFilter.pixelSize = value;
}

/**
Expand Down
Loading