Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the premultiply in shockwave filter #444

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

GoodBoyDigital
Copy link
Member

fixes #443

@bigtimebuddy
Copy link
Member

This definitely fixed the alpha issue, but now brightness property is not being respected.

Screen Shot 2024-02-19 at 3 22 15 PM Screen Shot 2024-02-19 at 3 22 08 PM

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve and merge this as is. I'll add that brightness not working on webgpu is a known issue to the release notes and we can do a fast-follow release to fix it later.

@bigtimebuddy bigtimebuddy merged commit 932a5b9 into main Mar 7, 2024
2 checks passed
@bigtimebuddy bigtimebuddy deleted the bugfix/shock-wave-filter branch March 7, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ShockwaveFilter WebGPU vs WebGL (PixiJS v8)
2 participants