Don't do a literal expansion for changed files #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-telemetry#36419) …e name logic <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Datadog associates two name fields with each span: "resource name" and "operation name." Resource name is analogous to `span.name` in OTel, but operation name has no 1:1 correspondence with any OTel fields. (Read more about what operation name respresents here: https://docs.datadoghq.com/tracing/guide/configuring-primary-operation/) Previously, the datadog exporter [would compute operation name as `{scope name}.{span kind}`](https://github.com/DataDog/datadog-agent/blob/8b92185df483f39456c41766b5666a2bd22307e6/pkg/trace/traceutil/otel_util.go#L367). This would result in long, difficult to read operation names in the Datadog UI - [a prior discussion on this issue can be found here](open-telemetry#1909). In this PR, add a feature gate `datadog.EnableOperationAndResourceNameV2`. This gate enables new logic for operation and resource name that improves readability of these fields by producing shorter names and better aligning with the OTel spec. The names computed in the new logic follow those computed in [dd-trace-go](https://github.com/DataDog/dd-trace-go). <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests and E2E tests for the new logic are done in the `datadog-agent` repo. Added a test in this repo that verifies that setting the feature gate enables the new logic; also ran the collector with the feature flag and verified new logic manually. <!--Describe the documentation added.--> #### Documentation Changelog added <!--Please delete paragraphs that you did not use before submitting.-->
Proposing to take the position of codeowner of jmxreceiver. Moving this component out of unmaintained status.
…ols (open-telemetry#37295) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Deprecates githubgen in favor of the new location of this code under opentelemetry-go-build-tools <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Related to open-telemetry#37294
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description `githubgen` was adding trailing whitespaces to unmaintained components that was unnecessary. This removes the trailing whitespaces. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37292
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Implements the common queueing feature into the `awss3exporter`, as suggested [here](open-telemetry#36264).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes
Testing
Documentation