#21 Refactor: checkPageExist 메서드 생성

pjhcsols · Sep 23, 2024 · 6fa0c78 · 6fa0c78
1 parent d282017
commit 6fa0c78
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/web3-credential-server/build/tmp/compileJava/previous-compilation-data.bin b/web3-credential-server/build/tmp/compileJava/previous-compilation-data.bin
diff --git a/web3-credential-server/src/main/java/web3/s3Storage/service/S3StorageService.java b/web3-credential-server/src/main/java/web3/s3Storage/service/S3StorageService.java
@@ -342,17 +342,15 @@ public void deletePdfForPage(Wallet wallet, int pageNumberToRemove) throws IOExc
         int pageIndexToRemove = pageNumberToRemove - 1;
 
         // 페이지가 존재하는지 확인
-        if (pageIndexToRemove < 0 || pageIndexToRemove >= totalPages) {
-            throw new IllegalArgumentException("Page number out of range: " + pageNumberToRemove);
-        }
+        checkPageExist(pageIndexToRemove < 0, pageIndexToRemove >= totalPages, "Page number out of range: " + pageNumberToRemove);
 
         byte[] frontPart = createPdfBytesPart(originalDocument, 0, pageIndexToRemove);
         byte[] backPart = createPdfBytesPart(originalDocument, pageIndexToRemove + 1, originalDocument.getNumberOfPages());
 
         // PDF 합치기
         byte[] finalPdfBytes = mergePdfs(frontPart,backPart);
         HashMap<String, String> metadata = getPdfMetadata(fileName);
-
+        log.info("metadata = {}",metadata);
         metadata.remove("page-" + pageNumberToRemove);
 
         // 최종 PDF를 S3에 업로드
@@ -366,6 +364,12 @@ public void deletePdfForPage(Wallet wallet, int pageNumberToRemove) throws IOExc
 
     }
 
+    private static void checkPageExist(boolean pageIndexToRemove, boolean pageIndexToRemove1, String pageNumberToRemove) {
+        if (pageIndexToRemove || pageIndexToRemove1) {
+            throw new IllegalArgumentException(pageNumberToRemove);
+        }
+    }
+
     public ResponseInputStream<GetObjectResponse> getPdf(String pdfUrl) {
         String key = extractKeyFromUrl(pdfUrl);
         GetObjectRequest getObjectRequest = GetObjectRequest.builder()