#10874 Omit WORKFLOW_STAGE_ID_SUBMISSION stage for OPS

pkp · Feb 5, 2025 · 7b53dd0 · 7b53dd0
1 parent 1416c01
commit 7b53dd0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/controllers/grid/settings/sections/form/PKPSectionForm.php b/controllers/grid/settings/sections/form/PKPSectionForm.php
@@ -115,7 +115,10 @@ public function fetch($request, $template = null, $display = false)
         $assignableUserGroups = UserGroup::query()
             ->withContextIds([$request->getContext()->getId()])
             ->withRoleIds($this->assignableRoles)
-            ->withStageIds([WORKFLOW_STAGE_ID_SUBMISSION])
+            ->withStageIds([
+                // WORKFLOW_STAGE_ID_SUBMISSION for OJS/OMP and WORKFLOW_STAGE_ID_PRODUCTION for OPS, see pkp/pkp-lib#10874
+                min(Application::getApplicationStages())
+            ])
             ->get()
             ->map(function (UserGroup $userGroup) use ($request) {
                 return [

diff --git a/pages/submission/PKPSubmissionHandler.php b/pages/submission/PKPSubmissionHandler.php
@@ -858,7 +858,10 @@ protected function getWorkflowUrl(Submission $submission, User $user): string
         // Replaces StageAssignmentDAO::getBySubmissionAndRoleIds
         $hasStageAssignments = StageAssignment::withSubmissionIds([$submission->getId()])
             ->withRoleIds([Role::ROLE_ID_AUTHOR])
-            ->withStageIds([WORKFLOW_STAGE_ID_SUBMISSION])
+            ->withStageIds([
+                // WORKFLOW_STAGE_ID_SUBMISSION for OJS/OMP and WORKFLOW_STAGE_ID_PRODUCTION for OPS, see pkp/pkp-lib#10874
+                min(Application::getApplicationStages())
+            ])
             ->withUserId($user->getId())
             ->exists();